authn: test against (non) nil CA #365
Closed
+127
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibihim
force-pushed
the
ibihim/2025-03-14_nil-type-non-nil-interface-issue
branch
from
ac5970b to
61966f1
Compare
stlaz
requested changes
Apr 8, 2025
| return ts | ||
| } | ||
|
|
||
| func TestNewOIDCAuthenticator(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
This only tests the CAs used in the authenticator.
Either rename the test or dedicate some time to turn this into table tests for the whole authenticator config (the latter is preferred).
| defer ts.Close() | ||
|
|
||
| // Override the default transport to skip TLS verification. | ||
| // This is needed because ts uses a self-signed certificate. |
Collaborator
There was a problem hiding this comment.
That's not a reason to do this. Why do you actually need it? Who uses the client?
|
|
||
| // Override the default transport to skip TLS verification. | ||
| // This is needed because ts uses a self-signed certificate. | ||
| // This should be legit for testing purpose, even with parallel test cases run at the same time. |
Collaborator
There was a problem hiding this comment.
I don't think this is legit.
Collaborator
Author
|
not worth the effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add unit tests to test the OIDC logic.
Why
There was an issue before and a comment isn't good enough to protect someone in the future from breaking it 😄